You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Process tasks: no more kernel injection, sub-process buffer in the temporary directory #318
CommandRunnerTask, ProcessLauncherTask and SubprocessInstance receive the whole @kernel (KernelInterface), only for getProjectDir(), getEnvironment() and getLogDir() (checked on main @ 96fa40b, config/services/task.yaml:238,256):
CommandRunnerTask::59: cwd = getProjectDir() (with the comment "This method is not actually in the interface, this is bad");
SubprocessInstance::59-62: the console is <project dir>/bin/console (hard-coded), the JSON buffer of the sub-process output is written in <project dir>/var/cdm_buffer_<id>.json-stream (the project directory may be read-only, e.g. in a container), and <log dir>/process is created by buildProcess() but never used.
v5 (no BC break)
Write the buffer in the system temporary directory (sys_get_temp_dir()) instead of <project dir>/var/: the path is still the output of ProcessLauncherTask.
Stop creating the unused <log dir>/process directory.
Allow the services to receive the paths and the environment (%kernel.project_dir%, %kernel.environment%) instead of the kernel, the kernel argument being deprecated (same approach as the ProcessManager container argument).
v6.0 (#292): the constructors take the paths and the environment only, no more KernelInterface.
Requirements
Documentation updates
Reference
Cookbooks
Changelog
Unit tests
Breaking changes
None in v5: the kernel argument is deprecated, the buffer moves to the temporary directory (its path is still given as output). Removal of the kernel arguments in v6.0.
Activity
Merge pull request #322 from cleverage/318