You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Define the public API: mark classes @final or @internal #56
No class of the bundle is final, @final or @internal (except the #[As…] attributes): the whole code base is an extension point, so any refactoring (constructor change, renamed protected method) is potentially a breaking change.
process-bundle did it in cleverage/process-bundle#279: @final since 5.4 on the classes not meant to be extended, @internal on the infrastructure classes (extension, compiler passes, commands, listeners). The Symfony DebugClassLoader then triggers a deprecation for the classes extending a @final one, giving one minor version of notice.
Proposed fix
2.3: add @final since 2.3 and @internal annotations.
Found during the Symfony bundle best practices review of the bridges.
Requirements
Documentation updates
Reference
Cookbooks
Changelog
Unit tests
Breaking changes
None in 2.3 (annotations only, extending a @final class triggers a deprecation). Major (3.0): extending a class that becomes final, or using an @internal class, is no longer supported.
Activity
#56 - Mark the classes not meant to be extended @Final and the infras…
Merge pull request #59 from cleverage/56