Repository navigation
fix(clerk-js): Use authQueryString when building callback URLs - #4961
Merged
Merged
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexcarpenter
approved these changes
Jan 21, 2025
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where certain query parameters were not preserved due to us passing an empty
authQueryStringto thebuildRedirectUrlcall forssoCallbackUrl. This resulted in the generation ofssoCallbackUrlvalues that did not retain important parameters such assign_in_force_redirect_url.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change