Repository navigation
fix(clerk-js): Use modal types for modal methods - #4931
Conversation
🦋 Changeset detectedLatest commit: fb9327c The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| * @param props Optional props that will be passed to the Waitlist component. | ||
| */ | ||
| openWaitlist: (props?: WaitlistProps) => void; | ||
| openWaitlist: (props?: WaitlistModalProps) => void; |
There was a problem hiding this comment.
This is equivalent, but no harm in being consistent.
|
!snapshot |
|
Hey @alexcarpenter - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/astro@2.1.11-snapshot.v20250117210429 --save-exact
npm i @clerk/backend@1.23.3-snapshot.v20250117210429 --save-exact
npm i @clerk/chrome-extension@2.1.15-snapshot.v20250117210429 --save-exact
npm i @clerk/clerk-js@5.45.2-snapshot.v20250117210429 --save-exact
npm i @clerk/elements@0.22.11-snapshot.v20250117210429 --save-exact
npm i @clerk/clerk-expo@2.6.14-snapshot.v20250117210429 --save-exact
npm i @clerk/expo-passkeys@0.1.10-snapshot.v20250117210429 --save-exact
npm i @clerk/express@1.3.38-snapshot.v20250117210429 --save-exact
npm i @clerk/fastify@2.1.11-snapshot.v20250117210429 --save-exact
npm i @clerk/localizations@3.9.11-snapshot.v20250117210429 --save-exact
npm i @clerk/nextjs@6.9.14-snapshot.v20250117210429 --save-exact
npm i @clerk/nuxt@1.0.7-snapshot.v20250117210429 --save-exact
npm i @clerk/clerk-react@5.22.2-snapshot.v20250117210429 --save-exact
npm i @clerk/react-router@0.2.1-snapshot.v20250117210429 --save-exact
npm i @clerk/remix@4.4.13-snapshot.v20250117210429 --save-exact
npm i @clerk/shared@2.20.10-snapshot.v20250117210429 --save-exact
npm i @clerk/tanstack-start@0.8.12-snapshot.v20250117210429 --save-exact
npm i @clerk/testing@1.4.11-snapshot.v20250117210429 --save-exact
npm i @clerk/themes@2.2.9-snapshot.v20250117210429 --save-exact
npm i @clerk/types@4.41.2-snapshot.v20250117210429 --save-exact
npm i @clerk/ui@0.3.12-snapshot.v20250117210429 --save-exact
npm i @clerk/vue@1.1.2-snapshot.v20250117210429 --save-exact |
Description
With the current types, routing options are available in the modal methods which is not relevant in modal usage. This PR updates the types to use the modal specific types which does not include routing or path.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change