Repository navigation
Localizations - #372
Merged
Merged
Localizations#372
Conversation
nikosdouvlis
commented
Sep 12, 2022
nikosdouvlis
force-pushed
the
localizations_wip
branch
3 times, most recently
from
September 13, 2022 10:23
a4abe8f to
463c3f9
Compare
nikosdouvlis
force-pushed
the
localizations_wip
branch
2 times, most recently
from
September 13, 2022 10:57
47ba7b2 to
55f639d
Compare
nikosdouvlis
force-pushed
the
localizations_wip
branch
3 times, most recently
from
September 13, 2022 22:59
9e220bb to
2e3065f
Compare
nikosdouvlis
force-pushed
the
localizations_wip
branch
from
September 14, 2022 07:00
2e3065f to
4e673ed
Compare
nikosdouvlis
commented
Sep 14, 2022
| }; | ||
| }; | ||
| userProfile: { | ||
| headerTitle__account: LocalizationValue; |
Member
Author
There was a problem hiding this comment.
These keys are used in the UserProfile homepage. I'm thinking of nesting them under userProfile.home key so they feel more similar with the other UserProfile pages (eg: userProfile.usernamePage).
Thoughts?
Member
|
Can you add the recommended usage pattern here as a comment? |
SokratisVidros
approved these changes
Sep 14, 2022
|
|
||
| export type RecordToPath<T> = PathImpl2<T> extends string | keyof T ? PathImpl2<T> : keyof T; | ||
|
|
||
| export type PathValue<T, P extends RecordToPath<T>> = P extends `${infer Key}.${infer Rest}` |
Contributor
There was a problem hiding this comment.
@nikosdouvlis Can you provide some more context on these type helpers to help the future reader?
| }; | ||
| }; | ||
| userProfile: { | ||
| headerTitle__account: LocalizationValue; |
SokratisVidros
approved these changes
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/clerk-expo@clerk/backend-core@clerk/clerk-sdk-node@clerk/edgebuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.