You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs(expo): open the verify PR as a draft until the evidence is in - #10620
The verify-clerk-expo skill now has the agent open its pull request as a draft with gh pr create --draft, run attach and down, and only then run gh pr ready <n>. For a remote session, where the evidence reaches the description about a minute after down, it first checks that gh pr view <n> --json body shows the verify-evidence block. references/remote.md says the same.
Why: review bots such as CodeRabbit review a pull request when it opens or turns ready, and read the description as it is then. The skill had the agent open the PR ready and attach right after, so the first review could miss the evidence. On clerk/clerk-ios#805 the evidence landed 16 seconds after the PR opened, and CodeRabbit's device evidence check failed on the earlier description. This repo's CI also skips drafts, so it starts once the PR turns ready. Same change as the clerk-ios and clerk-android skills.
In a Claude Code cloud session GitHub's GraphQL API is blocked, so gh pr create, gh pr view and gh pr ready fail there. The skill names the REST forms that work, including POST repos/clerk/javascript/pulls/<n>/ccr/ready_for_review, which a cloud session confirmed on a clerk-ios test PR. The wait for the evidence polls the description over REST for the table row and gives up after ten minutes.
Docs only.
Checklist
pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
CodeRabbit reviews a PR when it opens or turns ready and judges the
description it reads then. A PR opened ready was reviewed before attach
wrote the evidence, so its device evidence check failed (clerk-ios#805).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The verification instructions now direct users to create a draft pull request, attach before-and-after evidence, run down, and check for the verify-evidence table before marking the pull request ready. They also note that review bots may review when a pull request opens or becomes ready. A changeset file gains an empty front-matter block.
clerk/javascript#10400: Updates evidence publication to use one combined table, which this change checks before marking the pull request ready.
clerk/javascript#10556: Updates the Expo E2E evidence source and trace path used in the same run-and-attach workflow.
clerk/javascript#10576: Updates the verify-clerk-expo workflow and related E2E run and evidence instructions.
Merge Risk: Low · up to 07073
This docs-only change makes verification PRs open as drafts and become ready only after the evidence table appears. The remaining note is that marking the PR ready is an automatic step with no confirmation, a deliberate tradeoff for unattended runs. It is bounded and does not block merge.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title names the main change: the verify-clerk-expo skill now opens the verify PR as a draft until the evidence is attached. It uses the docs(expo) prefix, which matches the documentation-only chan…
Description check
The description matches the changeset. It explains that the verify-clerk-expo skill now opens PRs as drafts with gh pr create --draft, runs attach and down, and then runs gh pr ready. It also says ref…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: the verify-clerk-expo skill now opens the verify PR as a draft until the evidence is attached. It uses the docs(expo) prefix, which matches the documentation-only change. The title is specific and matches the changeset, which edits the skill docs and changeset front-matter.
Full details: Description check
Explanation
The description matches the changeset. It explains that the verify-clerk-expo skill now opens PRs as drafts with gh pr create --draft, runs attach and down, and then runs gh pr ready. It also says references/remote.md was updated to match, which the raw summary confirms. The rationale is given, and the description is specific about the change.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.
CodeRabbit Verify
Run CodeRabbit Verify to test the changes in this pull request.
Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Description
The
verify-clerk-exposkill now has the agent open its pull request as a draft withgh pr create --draft, runattachanddown, and only then rungh pr ready <n>. For a remote session, where the evidence reaches the description about a minute afterdown, it first checks thatgh pr view <n> --json bodyshows theverify-evidenceblock.references/remote.mdsays the same.Why: review bots such as CodeRabbit review a pull request when it opens or turns ready, and read the description as it is then. The skill had the agent open the PR ready and attach right after, so the first review could miss the evidence. On clerk/clerk-ios#805 the evidence landed 16 seconds after the PR opened, and CodeRabbit's device evidence check failed on the earlier description. This repo's CI also skips drafts, so it starts once the PR turns ready. Same change as the clerk-ios and clerk-android skills.
In a Claude Code cloud session GitHub's GraphQL API is blocked, so
gh pr create,gh pr viewandgh pr readyfail there. The skill names the REST forms that work, includingPOST repos/clerk/javascript/pulls/<n>/ccr/ready_for_review, which a cloud session confirmed on a clerk-ios test PR. The wait for the evidence polls the description over REST for the table row and gives up after ten minutes.Docs only.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
🤖 Generated with Claude Code