Skip to content

test(expo): pin the SDK 58 e2e fixture to react-native 0.88.1 - #10614

Merged
wobsoriano merged 1 commit into
mainfrom
rob/expo-fixture-rn-0-88-1
Nov 3, 2026
Merged

wobsoriano merged 1 commit into
mainfrom
rob/expo-fixture-rn-0-88-1

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

The iOS device tests on the release PR crash at launch with Symbol not found: _OBJC_CLASS_$_RCTStatusBarAppearance. expo-modules-core@58.0.30 now uses RCTStatusBarAppearance, which first ships in react-native 0.88.1, but the SDK 58 fixture pinned 0.88.0 while expo floats on ~58.0.12. This pins the fixture to 0.88.1, the version Expo 58 lists in bundledNativeModules.json. The new pin also changes the native fingerprint, so CI rebuilds the app instead of reusing the cached broken one.

Device run on this branch: run.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

🤖 Generated with Claude under Rob's supervision.

@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Nov 3, 2026 6:23pm UTC
swingset Ready Ready Preview Nov 3, 2026 6:23pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Nov 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d4b0de5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The Expo native fixture updates its react-native dependency from 0.88.0 to 0.88.1. The change also adds an empty changeset frontmatter block with no package or release entries.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • clerk/javascript#10384: Updates Expo native fingerprint inputs to include native package names and versions, which relate to the fixture’s React Native version.

Suggested reviewers: mikepitre

Merge Risk: Minimal · up to d4b0d

No actionable merge-blocking risk is evident in this fixture-only update.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title names the main change: the SDK 58 Expo e2e fixture is pinned to react-native 0.88.1. The raw summary confirms the fixture's react-native dependency moves from 0.88.0 to 0.88.1. The title is …
Description check Passed The description explains the change. It covers the iOS launch crash (Symbol not found: _OBJC_CLASS_$_RCTStatusBarAppearance), the cause (expo-modules-core@58.0.30 needs react-native 0.88.1), and the…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the SDK 58 Expo e2e fixture is pinned to react-native 0.88.1. The raw summary confirms the fixture's react-native dependency moves from 0.88.0 to 0.88.1. The title is specific and accurate. The 'test(expo):' prefix fits the fixture change, and the title is concise at 61 characters.

Full details: Description check

Explanation

The description explains the change. It covers the iOS launch crash (Symbol not found: _OBJC_CLASS_$_RCTStatusBarAppearance), the cause (expo-modules-core@58.0.30 needs react-native 0.88.1), and the fix (pinning the SDK 58 fixture to 0.88.1). It also notes the effect on the native fingerprint and links a device run. It is related to the changeset, so it passes.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 457be8e and d4b0de5.

Files selected for processing: 2
  • .changeset/expo-fixture-rn-0-88-1.md
  • integration/templates/expo-native/package.sdk-58.json
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 7 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.

@pkg-pr-new

pkg-pr-new Bot commented Nov 3, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10614

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10614

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10614

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10614

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10614

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10614

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10614

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10614

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10614

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10614

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10614

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10614

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10614

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10614

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10614

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10614

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10614

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10614

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10614

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10614

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10614

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10614

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10614

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10614

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10614

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10614

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10614

commit: d4b0de5

@blacksmith-sh

blacksmith-sh Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Matches Fixture resolves a react-native that has RCTStatusBarAppearance

Before, the fixture installs react-native 0.88.0, which has no RCTStatusBarAppearance, beside expo-modules-core 58.0.30 that calls it. After, it installs 0.88.1, which ships the class and matches Expo 58's bundled version.

Merge-base

Installed RN, before

This PR d4b0de55

Installed RN, after

Usage and Expo bundled pin

Also checked · 1 match · 1 not run

Blocked iOS app launches without the symbol crash · Blocked
Matches Native fingerprint changes, forcing a rebuild

Proof on d4b0de55 · Did Proof get it right? Yes · No

View full Proof report

@wobsoriano
wobsoriano enabled auto-merge (squash) November 3, 2026 18:33
@wobsoriano
wobsoriano disabled auto-merge November 3, 2026 18:33
@wobsoriano
wobsoriano merged commit 1c8f888 into main Nov 3, 2026
63 checks passed
@wobsoriano
wobsoriano deleted the rob/expo-fixture-rn-0-88-1 branch November 3, 2026 18:33

This branch was successfully deployed

2 active deployments
Preview – swingset — d4b0de55 Deployed Nov 3, 2026 by vercel[bot]
Preview – clerk-js-sandbox — d4b0de55 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants