Skip to content

ClerkExpressRequireAuth doesn't have any argument types #1938

New issue
New issue
Closed
Closed
ClerkExpressRequireAuth doesn't have any argument types#1938
Assignees
dimkl
Labels
prioritizedThis issue has been triaged and the team is working on it

Description

@tmcw
tmcw
opened on Oct 25, 2023

Preliminary Checks

Reproduction / Replay Link

.

Publishable key

.

Description

Steps to reproduce:

  1. Import and use ClerkExpressWithAuth

Expected behavior:

The method should require its arguments are ClerkMiddlewareOptions like here:

https://github.com/clerkinc/javascript/blob/main/packages/sdk-node/src/clerkExpressWithAuth.ts#L13C20-L13C42

Actual behavior:

It doesn't, the wrapper method has type ...args: any:

https://github.com/clerkinc/javascript/blob/main/packages/sdk-node/src/clerkClient.ts#L78

So, you don't get any type safety using this method.

Environment

This is in the main branch of this repo.

Activity

  1. tmcw
    added
    needs-triageA ticket that needs to be triaged by a team member
    on Oct 25, 2023
  2. dimkl
    added a commit that references this issue on Oct 25, 2023

    fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRe…

    104818f
  3. dimkl
    self-assigned this
    on Oct 25, 2023
  4. dimkl
    added a commit that references this issue on Oct 25, 2023

    fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRe…

    1238c22
  5. github-merge-queue
    added a commit that references this issue on Oct 26, 2023

    fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRe…

    5d379bc
  6. LekoArts
    added a commit that references this issue on Oct 26, 2023

    fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRe…

    b595946
  7. dimkl
    added 2 commits that reference this issue on Oct 30, 2023

    fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRe…

    a2c4b95

    fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRe…

    74649e1
  8. jescalan
    added
    prioritizedThis issue has been triaged and the team is working on it
    and removed
    needs-triageA ticket that needs to be triaged by a team member
    on Oct 30, 2023
  9. panteliselef
    added a commit that references this issue on Oct 30, 2023

    fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRe…

    7b5a774
  10. octoper
    added a commit that references this issue on Oct 31, 2023

    fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRe…

    1cd322d
  11. dimkl
    added a commit that references this issue on Oct 31, 2023

    fix(clerk-sdk-node): Fix types of ClerkExpressWithAuth/ClerkExpressRe…

    a265b74
  12. github-merge-queue
    added a commit that references this issue on Oct 31, 2023

    fix: Types and NextJS 14 support (#1939, #1948) (#1968)

    a605335

  13. tmcw commented on Mar 5, 2024

    @tmcw
    tmcw
    on Mar 5, 2024
    Author

    Is this fixed? It seems fixed, but is not closed.

  14. LekoArts commented on Mar 6, 2024

    @LekoArts
    LekoArts
    on Mar 6, 2024
    Contributor

    This was fixed by #1939, yes 👍

  15. LekoArts
    closed this as completedon Mar 6, 2024

  16. clerk-cookie commented on Mar 7, 2025

    @clerk-cookie
    clerk-cookie
    on Mar 7, 2025
    Collaborator

    This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

  17. clerk
    locked as resolved and limited conversation to collaborators on Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

prioritizedThis issue has been triaged and the team is working on it

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions