Skip to content

[bug]: notation.lua is missing from the rockspec #38

Closed
#39
Closed
[bug]: notation.lua is missing from the rockspec#38
#39

Description

@Tieske
Tieske
opened on Nov 26, 2024

The file is in the repo, but not in the rockspec, so won't get installed.

Activity

  1. Tieske
    added 2 commits that reference this issue on Nov 26, 2024

    fix(rockspec): include 'notation.lua'

    0bf69ae

    fix(rockspec): include 'notation.lua'

    d626970

  2. Tieske commented on Nov 26, 2024

    @Tieske
    Tieske
    on Nov 26, 2024
    ContributorAuthor

    fix is in #37

  3. kou commented on Nov 26, 2024

    @kou
    kou
    on Nov 26, 2024
    Member

    Could you open a separated PR instead of adding unrelated changes to one PR?

  4. Tieske
    added a commit that references this issue on Nov 27, 2024

    fix(rockspec): include 'notation.lua'

    0ac75d2
  5. kou
    added a commit that references this issue on Nov 27, 2024

    fix(rockspec): include 'notation.lua' (#39)

    c3bf1dd
  6. kou
    closed this as completedin #39on Nov 27, 2024

  7. Tieske commented on Nov 27, 2024

    @Tieske
    Tieske
    on Nov 27, 2024
    ContributorAuthor

    #39 is now a separate PR for this. It is related however, since #37 fails hard without this fix.

  8. kou commented on Nov 27, 2024

    @kou
    kou
    on Nov 27, 2024
    Member

    I've merged #39. Could you rebase #37 on master?

  9. Tieske commented on Nov 27, 2024

    @Tieske
    Tieske
    on Nov 27, 2024
    ContributorAuthor

    done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions