Repository navigation
Expose live turn control in ACP and VS Code - #53
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…paction pinning - Stage snapshot replacements with the target's Unix mode before writing content, and report a target deleted mid-staging as stale. - Document that snapshot publication does not keep owner/ACLs/xattrs. - write_file and edit_file take the shared semantic-write lock. - REPL: keep the session open on non-provider prompt failures; return nonzero for unknown slash commands and failed custom commands; keep the last exit code on idle Ctrl+C. - Compaction: check the summary budget only once compaction is needed, and pin the turn's original request as well as the latest correction. - Keep provider-reported usage when the response text is empty. - Add coverage for staging recheck, precheck cancellation, snapshot symlink escape, unfinished primary compaction, and cancel isolation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ontrol' into codex/runtime-resilience # Conflicts: # src/SharpClaw.Code.Runtime/Context/AutomaticContextManager.cs
# Conflicts: # tests/SharpClaw.Code.IntegrationTests/Runtime/InteractiveMilestoneTests.cs
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VS Code users can steer or cancel an active SharpClaw prompt and see tool activity in the output channel. ACP controls match the connection, workspace, session and original prompt request ID. Corrections that arrive too late remain available in the prompt result or error for resubmission.
The client initializes one subprocess for concurrent commands, rejects pending calls when it exits and binds approval replies to the connection that requested them. Closing the editor's input releases approval waits and cancels opted-in turns. Embedded hosts that require authenticated approvals check the principal and tenant before showing an editor approval.
Validation
Compatibility
Live control is opt-in per prompt and advertised by the host. Existing clients keep their prompt and result formats. The extension uses ordinary prompts with older hosts. Live progress carries tool names and completion status. Tool input and output stay in the permission-aware runtime.
Stacked on PR #52. The repository's cross-platform CI workflow targets PRs into
main.