Repository navigation
Liz Patch November - #258
Open
Legate-Elizabeth wants to merge 6 commits into
Open
Legate-Elizabeth wants to merge 6 commits into
Legate-Elizabeth wants to merge 6 commits into
Conversation
Ensured that characters can't burn out on their first time, as was intended Completely removed the need for a lengthy scripted_effect used only in this event chain, improving code readability and efficiency Gave all characters that engage in self-improvement an ego-check, so they no longer gain opinion of themselves
Swapped 'vassal_of' for 'liege =' since the event chain is checking for courtiers who, famously, aren't vassals. Allowed disobedient daughters to shirk social norms and get matrilineally married if you let them. We love to see a girlboss winning.
Successful or cancelled, the 'do not disturb' flag isn't removed for the actual coronation target. Even if it is, it would make more sense to add the flag when the actual ceremony begins, not when it's requested.
Whizzer
reviewed
Nov 8, 2026
|
|
||
| clr_character_flag = disobedient_daughter_unhappy | ||
| add_spouse = event_target:target_daughter_wants_to_marry # TODO: shouldn't this marry matrillineally under some circumstances? Perhaps even all the time, since their parent is a player? | ||
| clr_character_flag = disobedient_daughter_unhapp |
Whizzer
reviewed
Nov 8, 2026
| has_character_flag = disobedient_daughter | ||
| is_female = yes | ||
| vassal_of = ROOT | ||
| liege = { character = ROOT } |
Contributor
There was a problem hiding this comment.
Courtiers do, in fact, count as vassals. All it checks for is the liege relationship. Blame Paradox and their poorly chosen names for many triggers and effects.
Previously sent a notification event telling you you'd gotten over depression without actually removing the trait. Now it just fires the baseline event for removing depression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.