Repository navigation
Conversation
Northrim
requested review from
alex-ozdemir and
edwjchen
and removed request for
alex-ozdemir
January 10, 2022 21:29
alex-ozdemir
requested changes
Jan 10, 2022
alex-ozdemir
left a comment
alex-ozdemir
left a comment
Contributor
There was a problem hiding this comment.
Looks good so far, William. I have a few suggestions within.
…rs, encryption, making the server function call, decryption.
edwjchen
requested changes
Mar 31, 2022
edwjchen
reviewed
Apr 26, 2022
Collaborator
There was a problem hiding this comment.
Left a few small comments!
@alex-ozdemir when you have a minute, could you take a look at the Map IR lowering?
alex-ozdemir
approved these changes
Apr 27, 2022
alex-ozdemir
left a comment
alex-ozdemir
left a comment
Contributor
There was a problem hiding this comment.
I left a nit and two questions.
edwjchen
self-requested a review
April 27, 2022 05:28
edwjchen
approved these changes
Apr 27, 2022
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.