Skip to content

Javascript Client Request Issue #66

Open

Description

@jbspears

Looks like the client _requests_by_id and _requests_by_timestamp are Map objects and should use set/get. Also, the timeout passed to the request method is multiplied by 1000000. I would think since the timestamp is milliseconds and the timeout is milliseconds that no conversion would be needed. Once I modified the Map objects to use set/get and removed the timeout multiplier, the client request seemed to work as expected. Thanks.

Activity

  1. chronoxor commented on May 12, 2022

    @chronoxor
    Owner

    Will look into this issue! Thanks for reporting!

  2. chronoxor commented on May 19, 2022

    @chronoxor
    Owner

    Fixed! Thanks for reporting! Can you please check the fix on your side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions