1.6 Length bug #14

Activity

1. dawsbot

   changed the title [-]1.6 length bug[/-] [+]1.6 Length bug[/+] on May 21, 2017
2. dawsbot commented on May 21, 2017

   

   dawsbot

   on May 21, 2017

   ContributorAuthor

   More actions

   Do you want to fix this @tankwan? I can if not.
3. heytonytan commented on May 22, 2017

   

   heytonytan

   on May 22, 2017 via email

   Collaborator

   More actions

   Hey @dawsbot, hope you're having a great weekend! Sure thing, I can take care of it :)

   …

   On Sun, 21 May 2017 at 14:02 Dawson Botsford ***@***.***> wrote: Do you want to fix this @tankwan <https://github.com/tankwan>? I can if not. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEhn5XRlVvasQXycgtMpLJwhFUE1HGjHks5r8KZ_gaJpZM4NhuTU> .

   👍React with 👍1Reacted by Raziyeh Bazargan
4. profnandaa commented on Oct 2, 2018

   

   profnandaa

   on Oct 2, 2018

   Collaborator

   More actions

   @thetonytan - ping!

   👍React with 👍1Reacted by Dawson Botsford
5. yuriaps commented on Sep 27, 2020

   

   yuriaps

   on Sep 27, 2020

   Last edited by yuriaps

   More actions

   Bug in this test
   console.log('aabbcc', strComp('aabbcc'), 'aabbcc')
   As the book says, if the length of the result is not less than the original should print the original, and it is printing:
   a2b2c2
6. yuriaps commented on Sep 27, 2020

   

   yuriaps

   on Sep 27, 2020

   More actions

   I don't see why use the Math.max()...
   I would go this way

   var strComp = function(string) {
       var compressed = '';
       var currChar = '';
       var currCount = '';
       for (var i = 0; i < string.length; i++) {
         if (currChar !== string[i]) {
           compressed = compressed + currChar + currCount;
           currChar = string[i];
           currCount = 1;
         } else {
           currCount++;
         }
       }
       compressed = compressed + currChar + currCount;
     
       return compressed.length >= string.length ? string : compressed;
     };