Repository navigation
ci: compare fixtures with Ruby main - #71
Merged
Merged
Conversation
The ledger cited Ruby solid_objects 0.17.2, and RubyGems has 0.17.3. Ruby 0.17.3 adds four problem guides, their tests, and activejob in the development bundle. Between the tags v0.17.2 and v0.17.3, the only file in lib/ that changed is version.rb. The release has no runtime change, so the ledger needs no new row.
The four compatibility/*.json fixtures are committed to this repository and to solid-objects-ruby. Each suite reads its own copy, and no job compared the two copies, so one side could change a wire format and both suites would stay green. The new script compares the *.json files in two directories by name and by bytes. The new workflow runs it on this repository and on a sparse checkout of solid-objects-ruby at main. The workflow does not run on a pull request. During a paired change, the other repository holds the old fixture until the two pull requests merge.
|
Docs7 for cardmagic/solid-objects-js
Commit |
|
Greptile found that jsonFileNames had one caller and held one short expression. The reader had to go to the function to read the filter. Put the expression at the call site. The behavior does not change.
Owner
Author
|
@greptileai Please review the latest commit, 29202ce ("refactor: inline jsonFileNames helper"). It fixes the finding "Single-use helper adds a jump" in scripts/check-compatibility-fixtures.mjs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What changed
Limits
Failing test first
Before the script existed,
pnpm exec vitest run test/check-compatibility-fixtures.test.tsgave:After the script:
Test Files 1 passed (1),Tests 6 passed (6).Validation
pnpm run build: passed.pnpm run check: passed.pnpm run format:check: passed on a cleangit archiveexport of commit ae2ff29.pnpm test: 70 files, 623 passed, 32 skipped in 3 runs. In other runs, 1 to 3 tests in test/lifecycle.test.ts and test/sqlite.test.ts failed. The machine load average was above 60. The same tests failed in 5 of 6 runs with the new test file excluded, so this change is not the cause. The new test file passed in each run. A follow-up task records these timing tests.pnpm run test:browser: not run. This change does not touch browser code.node scripts/check-compatibility-fixtures.mjs compatibility <sparse clone>/compatibility: exit status 0.Sibling runtime
Ruby has no equivalent job. This workflow compares the two repositories, so one job covers both.