Repository navigation
Fix casing of includes for case-sensitive systems - #57
Merged
Merged
Conversation
TrueBrain
force-pushed
the
push-korqtzztlxpt
branch
2 times, most recently
from
August 11, 2026 20:41
0cf3f4f to
c33074a
Compare
TrueBrain
changed the title
TrueBrain
force-pushed
the
push-korqtzztlxpt
branch
from
August 12, 2026 18:31
c33074a to
f15e7c2
Compare
|
Looks good in principle, just need to rebase it. We have some other PR's making it through the pipeline once our v145 upgrade is finished. I would recommend doing it then, I will keep you notified |
For the include folder, more entries were using lower-case to include from it than upper-case. It also makes most sense, as the common naming of "include" folder is in lower case.
JohnGreenFC
force-pushed
the
push-korqtzztlxpt
branch
from
October 21, 2026 08:17
44be7ed to
84dd660
Compare
JohnGreenFC
approved these changes
Oct 23, 2026
filipppavlov
approved these changes
Oct 26, 2026
|
@TrueBrain Thank you for the contribution, I'm confirming its now in the codebase! |
JuhDuh26
added a commit
to JuhDuh26/trinity
that referenced
this pull request
Oct 26, 2026
Main moved trinity/Include to trinity/include (carbonengine#57), which conflicted with this branch's edits to ITr2ValueBinding.h and CMakeLists.txt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the include folder, more entries were using lower-case to include from it than upper-case. It also makes most sense, as the common naming of "include" folder is in lower case.
A next step into making this repository compile on Linux.
Full disclosure: I am employed by Fenris Creations, although I have no involvement with the Carbon project. I work on this in my free time under my own name.