Repository navigation
fix(website): warn instead of failing while the hero film is stale - #835
Conversation
…pushes The site now deploys when the changesets workflow tags and publishes nostream-website@X.Y.Z (the release event this workflow filters on). Merging relay work to main no longer touches the site deploy; a site deploy happens exactly when a release PR that bumps nostream-website merges. Checkout on a release event is the tagged commit, so the deployed assets are the released build. Relay image releases keep their v* gate in release.yml — the tag namespaces do not overlap. workflow_dispatch remains for manual deploys of main.
The film guard hard-failed every site build since #830 added NIP-77 (supportedNips 24 -> 25): re-rendering the film needs the GPU pipeline and no GPU is available to the sandbox or the runners. Per operator order the mismatch branch now warns (loudly, with the re-render commands) and exits 0, unblocking releases; the comment in the script names the day, the order, and where to restore exit 1.
🦋 Changeset detectedLatest commit: 44fbd69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
 [Medium impact] Softens a build guard to allow stale marketing film. Restore the branch check for manual production deployments before merging. Findings
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| if: github.event_name != 'workflow_dispatch' || github.ref == 'refs/heads/main' | ||
| if: >- | ||
| ${{ startsWith(github.event.release.tag_name, 'nostream-website@') || | ||
| github.event_name == 'workflow_dispatch' }} |
There was a problem hiding this comment.
The new workflow_dispatch condition allows manual runs from any branch. actions/checkout@v3 checks out the selected branch, and wrangler deploy sends that build to the production domain. A manual run from a feature branch can therefore replace the live website with unmerged changes. Keep the refs/heads/main check for manual runs while allowing website release tags.
| github.event_name == 'workflow_dispatch' }} | |
| (github.event_name == 'workflow_dispatch' && github.ref == 'refs/heads/main') }} |
2 participants
Problem
Every site build has failed since #830 added NIP-77:
check-hero-nipshard-fails onhero film shows 24 NIPs but package.json has 25. The re-render (website/hero-animation→ framefields → WebGPU) needs a GPU that neither the sandbox nor the GitHub runners have, so this blocks the site deploy — and with the release-driven deploy flow (#834), every nostream-website release.Change
On operator order, the mismatch branch of the guard now warns loudly (STALE FILM + the exact re-render commands) and exits 0. The in-script comment records the date, the order, and that
process.exit(1)must be restored once the film is re-rendered.Deliberately a warning, not silent acceptance: the log line still says the film is stale on every build until it's fixed.
Restoration
Re-render needs the GPU render container back on the host:
containers/gpu-render/gpu-render-setup.sh --apply, thencd website/hero-animation && pnpm run render && pnpm run frames,cd ../site && pnpm run media, commit the new mp4+meta, then flip the guard back toexit 1.