Repository navigation
fix(website): narrow the deploy trigger to website-affecting paths - #833
chappie-daemon wants to merge 1 commit into
Conversation
The deploy ran for #830 (a relay change: NIP-77 in NIP-11 + admin console) because the trigger included package.json, docs/** and the repo markdown files. The site reads exactly three things outside website/site: the workspace split (pnpm-workspace.yaml), the lockfile (workspace deps), and this workflow itself. Relay source, docs and root markdown no longer trigger a deploy. Known consequence surfaced by the same run: the hero-film guard (check-hero-nips) compares hero.meta.json against package.json, so a supportedNips change (24 -> 25 in #830) fails the site build until the film is re-rendered. That re-render needs the GPU render container (host-side setup), so it is tracked separately.
|
|
Superseded: deploy should key off the changesets release (nostream-website version bump), not each main push. Rebuilding as a release-triggered workflow. |
 [High impact] Changes when the website deployment workflow runs. Restore triggers for the Markdown files used by the website before merging. Findings
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| - "website/site/**" | ||
| - "pnpm-workspace.yaml" | ||
| - "pnpm-lock.yaml" | ||
| - "package.json" | ||
| - "README.md" | ||
| - "CLI.md" | ||
| - "CONFIGURATION.md" | ||
| - "CONTRIBUTING.md" | ||
| - "SECURITY.md" | ||
| - "CHANGELOG.md" | ||
| - "deploy/**" | ||
| - "docs/**" | ||
| - ".github/workflows/deploy-website.yml" |
There was a problem hiding this comment.
The removed Markdown paths still supply website pages. content.config.ts reads the files listed in DOCS and the root CHANGELOG.md, then the site renders them into published pages. A change only to docs/REDIS.md, for example, will no longer trigger deployment, so readers keep seeing the old guide until an unrelated deployment.
Keep triggers for the Markdown files the site actually reads. The broader directory filters can still be narrowed.
1 participant
Problem
Deploy Website ran for #830 — a relay-only change (NIP-77 advertisement in NIP-11 + admin console settings). The old trigger paths included
package.json,docs/**and the root markdown files, so almost any relay PR poked the site workflow.What the site actually reads outside
website/site/Measured from the build inputs:
pnpm-workspace.yaml— workspace membership (nostream-websiteis a workspace package)pnpm-lock.yaml— workspace dependency install.github/workflows/deploy-website.yml— the workflow itselfRelay source, docs and root markdown no longer trigger a deploy. (The root
package.jsonsupportedNipslist flows into the site viasrc/data/site.ts, but a NIP change is a relay release — its release PR bumps the lockfile/version, which is already covered; the site's NIP grid updates on the next site-affecting deploy.)Related, same run
That failed run also exposed the hero-film guard failing (
check-hero-nips: film shows 24 NIPs, package.json now has 25) — a supportedNips change requires re-renderinghero.mp4via the framefields GPU pipeline before the site can deploy again. That is an environment/host-side task, tracked separately from this trigger fix.