Skip to content

Repository navigation

fix: bug unable confirm invoice - #204

Merged
cameri merged 4 commits into
mainfrom
193-bug-unable-confirm-invoice
Feb 15, 2023
Merged

fix: bug unable confirm invoice#204
cameri merged 4 commits into
mainfrom
193-bug-unable-confirm-invoice

Conversation

@cameri

@cameri cameri commented Feb 15, 2023

Copy link
Copy Markdown
Owner

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@cameri
chore: confirm only if bolt11 is present
b6dc2a8 
Signed-off-by: Ricardo Arturo Cabral Mejía <me@ricardocabral.io>
@cameri
fix: fix double invoice bug. thx mazin
b03a692
@coveralls

coveralls commented Feb 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 4180521012

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 59.043%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/controllers/callbacks/zebedee-callback-controller.ts 0 1 0.0%
src/controllers/invoices/post-invoice-controller.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 4179608750: 0.04%
Covered Lines: 1167
Relevant Lines: 1951
💛 - Coveralls

@sonarqubecloud

sonarqubecloud Bot commented Feb 15, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@cameri cameri changed the title 193 bug unable confirm invoice fix: bug unable confirm invoice Feb 15, 2023
@cameri
cameri merged commit bcd072e into main Feb 15, 2023
@cameri
cameri deleted the 193-bug-unable-confirm-invoice branch February 15, 2023 04:41
github-actions Bot pushed a commit that referenced this pull request Feb 15, 2023
@semantic-release-bot
chore(release): 1.22.3 [skip ci]
9f56750 
## [1.22.3](v1.22.2...v1.22.3) (2023-02-15)

### Bug Fixes

* bug unable confirm invoice ([#204](#204)) ([bcd072e](bcd072e))
* upgrade axios from 1.2.3 to 1.2.4 ([#203](#203)) ([b7c9b95](b7c9b95))
* upgrade knex from 2.4.1 to 2.4.2 ([#200](#200)) ([d985658](d985658))
@github-actions

github-actions Bot commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.22.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@cameri
cameri restored the 193-bug-unable-confirm-invoice branch February 15, 2023 04:49
@cameri
cameri deleted the 193-bug-unable-confirm-invoice branch February 15, 2023 04:50
@cameri cameri mentioned this pull request Feb 15, 2023
Closed
espetro pushed a commit to espetro/nostream that referenced this pull request Oct 18, 2026
@cameri
fix: bug unable confirm invoice (cameri#204)
628f312 
* chore: confirm only if bolt11 is present

Signed-off-by: Ricardo Arturo Cabral Mejía <me@ricardocabral.io>

* fix: fix double invoice bug. thx mazin

* fix: fypo tix on default-settings

* fix: use correct dbname on knexfile

---------

Signed-off-by: Ricardo Arturo Cabral Mejía <me@ricardocabral.io>
espetro pushed a commit to espetro/nostream that referenced this pull request Oct 18, 2026
@semantic-release-bot
chore(release): 1.22.3 [skip ci]
a0e5bf4 
## [1.22.3](cameri/nostream@v1.22.2...v1.22.3) (2023-02-15)

### Bug Fixes

* bug unable confirm invoice ([cameri#204](cameri#204)) ([bcd072e](cameri@bcd072e))
* upgrade axios from 1.2.3 to 1.2.4 ([cameri#203](cameri#203)) ([b7c9b95](cameri@b7c9b95))
* upgrade knex from 2.4.1 to 2.4.2 ([cameri#200](cameri#200)) ([d985658](cameri@d985658))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cameri @coveralls