[cameri]

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Non-functional change (docs, style, minor refactor)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my code changes.
• All new and existing tests passed.

[coveralls]

Pull Request Test Coverage Report for Build 3888916706

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 214 of 356 (60.11%) changed or added relevant lines in 37 files are covered.
• 119 unchanged lines in 11 files lost coverage.
• Overall coverage decreased (-16.4%) to 70.277%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/app/worker.ts	2	3	66.67%
src/payments-processors/null-payments-processor.ts	1	2	50.0%
src/handlers/request-handlers/post-zebedee-callback-request-handler.ts	2	4	50.0%
src/handlers/request-handlers/root-request-handler.ts	1	3	33.33%
src/payments-processors/payments-procesor.ts	1	3	33.33%
src/schemas/http-request-schemas.ts	0	3	0.0%
src/adapters/web-server-adapter.ts	1	5	20.0%
src/factories/worker-factory.ts	12	16	75.0%
src/factories/zebedee-callback-controller-factory.ts	5	9	55.56%
src/index.ts	0	4	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/index.ts	1	0.0%
src/utils/event.ts	1	92.14%
src/repositories/event-repository.ts	2	97.3%
src/factories/rate-limiter-factory.ts	4	45.45%
src/adapters/web-socket-server-adapter.ts	5	59.52%
src/app/worker.ts	5	38.1%
src/cache/client.ts	5	46.15%
src/app/app.ts	9	24.49%
src/adapters/redis-adapter.ts	11	7.89%
src/adapters/web-server-adapter.ts	21	25.0%

Totals
Change from base Build 3825451498:	-16.4%
Covered Lines:	866
Relevant Lines:	1228

---

💛 - Coveralls

[kevinsmith]

Wanted to send you the comments so far, but I'm gonna have to finish this up tomorrow.

[bleetube]

Afaict, relays that require payments always appear to be offline on monitors like nostr.watch. Is it possible to instead reserve nodejs workers for registered client pubkeys? Suppose you have a dedicated server with 16+ cpu cores, and have 12 workers answer public requests while reserving 4 workers to be available anytime a registered client makes a request? That way anyone with a public relay can provide higher reliability to clients that have registered by making a lightning payment.

ie. in settings.json

  "workers": {
    "public": 12,
    "private": 4
  },

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
1 Security Hotspot
16 Code Smells

32.9% Coverage
1.5% Duplication

[github-actions]

🎉 This PR is included in version 1.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀