Optimize unit tests: nip05.spec.ts & nip03.spec.ts (network) #610

Activity

1. Anshumancanrock

   self-assigned this

   on May 19, 2026
2. Ferryx349 commented on May 23, 2026

   

   Ferryx349

   on May 23, 2026

   Collaborator

   More actions

   @Anshumancanrock have u started working around it, or still up to grab?
3. Anshumancanrock commented on May 28, 2026

   

   Anshumancanrock

   on May 28, 2026

   Contributor

   More actions

   Hii @cameri , I dug into this and found that nip03.spec.ts is completely synchronous. It is just a binary parser with no network activity at all. The async tests in nip05.spec.ts rely on stub.resolves, which fires as a microtask rather than real IO. All 76 tests finish in roughly 40 ms locally.

   I did clean up the structural stuff though. I hoisted the stub lifecycle into the before and after hooks, pulled the SSRF guard out so it only runs once instead of repeating it for every test, and created the shared buffers ahead of time at module scope. Happy to open a PR if this helps.
4. cameri commented on May 28, 2026

   

   cameri

   on May 28, 2026

   Owner

   More actions

   @Anshumancanrock Okay not sure why it was taking longer on my machine when I inspected these tests. I'd appreciate if you open a PR with your structural changes.

   👍React with 👍1Reacted by Anshuman
5. Anshumancanrock

   closed this as completedon Aug 5, 2026