Repository navigation

Convert user admission to PostgreSQL stored function #435

Closed

Assignees

opened

on Apr 10, 2026

Convert user admission workflow to use a PostgreSQL stored function to replace the application-layer upsert during invoice confirmation flow.

This is to complete an explicit TODO in payments-service.ts.

Acceptance Criteria

Create admit_user database function using atomic ON CONFLICT DO UPDATE constraints
Preserve ASSERT_SERIALIZED() transaction guarantees
Add Knex migration to provision the function
Add admitUser interface and DB implementation in UserRepository
Verify existing repository tests pass

Related

See TODO in payments-service.ts

cameri commented on Apr 10, 2026
cameri
on Apr 10, 2026
Owner
@Mohit-Davar please comment here so I can assign you the issue
cameri
linked a pull request that will close this issueImplementes TODO in payments-service.ts. convert user admission to postgres stored function #428 on Apr 10, 2026
Mohit-Davar commented on Apr 10, 2026
Mohit-Davar
on Apr 10, 2026
Contributor
I worked on this issue in this pr #428
cameri
assigned
Mohit-Davar
on Apr 10, 2026
Mohit-Davar
added a commit that references this issue on Apr 11, 2026
refactor: convert user admission to postgres stored function
0861163
cameri
closed this as completedin #428 on Apr 18, 2026
cameri
added a commit that references this issue on Apr 18, 2026
refactor: convert user admission to postgres stored function (#428)
3f278f6
cameri commented on Apr 18, 2026
cameri
on Apr 18, 2026
Owner
thank you @Mohit-Davar
espetro
added a commit that references this issue on Oct 18, 2026
refactor: convert user admission to postgres stored function (cameri#428
5e62d70

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Mohit-Davar

Labels

No labels

No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests