Skip to content

Minimal IE Runtime - #446

Closed
nhooyr wants to merge 4 commits into
callstack:masterfrom
nhooyr:ie11runtime
Closed

nhooyr wants to merge 4 commits into
callstack:masterfrom
nhooyr:ie11runtime

Conversation

@nhooyr

@nhooyr nhooyr commented Jul 3, 2019

Copy link
Copy Markdown

See #445

Summary

Adds a very minimal runtime for IE. Not the most robust but should work well for our purposes.

See #445

Test plan

Not really sure yet.

@nhooyr nhooyr changed the title Initial Minimal IE Runtime Minimal IE Runtime Jul 3, 2019
@nhooyr
nhooyr marked this pull request as ready for review July 3, 2019 08:18
@nhooyr

nhooyr commented Jul 3, 2019

Copy link
Copy Markdown
Author

The way it work is that when a css variable needs to be modified, instead of just adding an inline style, the IE code will find the rule in the stylesheet that uses the css variable on the class, replace the variable with the value and add this new rule to a dynamically injected stylesheet.

@nhooyr

nhooyr commented Jul 3, 2019

Copy link
Copy Markdown
Author

Not sure if the rule cache here is necessary. For the rule on every dynamic CSS variable, is the selector just the class?

@pbitkowski

Copy link
Copy Markdown
Contributor

Thanks for your contribution! Is this possible to extract this logic to another library, to make this opt-in feature? I know it's tiny, but we don't to do it by default to keep our core small and happy.

@dreyks

dreyks commented Jul 15, 2019 •

Copy link
Copy Markdown

@pbitkowski how do you feel about making it a separate library indeed but scoping it under callstack? that way the core could still be kept small but the library won't get lost in the future?

@nhooyr

nhooyr commented Jul 22, 2019

Copy link
Copy Markdown
Author

Don't have the time to work on this anymore. Someone else feel free to continue.

@nhooyr nhooyr closed this Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants