Repository navigation
fix(assistant): dock the assistant beside the sidebar instead of floating over dialogs - #97
Merged
Conversation
…ting over dialogs
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
# Conflicts: # frontend/src/components/AppShell.vue
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58
The assistant was a floating window drawn on top of the Settings dialog. Settings is a modal (frappe-ui's dialog has no non-modal option), so the assistant looked usable but couldn't be clicked or typed into. It's now docked beside the sidebar like Bob in Builder: an Assistant item in the sidebar opens a resizable pane (280–560px, width remembered), and Settings covers it like the rest of the page. A running answer keeps streaming behind Settings and is there when you close it. Phones keep the full-screen chat.
Also switches the sidebar to frappe-ui's composed API: the deprecated
sectionsconfig never passedactivethrough, so no sidebar item ever showed as active.Screenshots
Docked

Settings open (answer still streaming behind it)

After closing Settings

Collapsed sidebar
