Skip to content

fix(assistant): dock the assistant beside the sidebar instead of floating over dialogs - #97

Merged
Rl0007 merged 3 commits into
bwhtech:mainfrom
vishwajeet-13:fix/agent-with-settings-open
Oct 6, 2026
Merged

Rl0007 merged 3 commits into
bwhtech:mainfrom
vishwajeet-13:fix/agent-with-settings-open

Conversation

@vishwajeet-13

Copy link
Copy Markdown
Collaborator

Closes #58

The assistant was a floating window drawn on top of the Settings dialog. Settings is a modal (frappe-ui's dialog has no non-modal option), so the assistant looked usable but couldn't be clicked or typed into. It's now docked beside the sidebar like Bob in Builder: an Assistant item in the sidebar opens a resizable pane (280–560px, width remembered), and Settings covers it like the rest of the page. A running answer keeps streaming behind Settings and is there when you close it. Phones keep the full-screen chat.

Also switches the sidebar to frappe-ui's composed API: the deprecated sections config never passed active through, so no sidebar item ever showed as active.

Screenshots

Docked
assistant-docked.png

Settings open (answer still streaming behind it)
assistant-settings-open.png

After closing Settings
assistant-after-settings.png

Collapsed sidebar
assistant-collapsed.png

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

# Conflicts:
#	frontend/src/components/AppShell.vue

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@Rl0007
Rl0007 merged commit 83a61af into bwhtech:main Oct 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent does not work with settings open

2 participants