Repository navigation
fix(remediate): save canonical pages in batches and resume a killed run - #86
Merged
Merged
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Rl0007
force-pushed
the
fix/remediate-batch-save
branch
from
October 6, 2026 05:02
425af97 to
f980b2d
Compare
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can visit an import's page in /wikify after a killed run and open Actions to see it.
Fixes #22
Merge #85 first; this PR is stacked on it.
Before
After
Verification
test_killed_run_keeps_saved_batches_and_resume_skips_them(25 pages, run killed at page 18): red on main ([] != [1..10]), green on this branch. A resumed run calls the page model 15 times, not 25. Removing the batch commit also fails it (0 != 1).TestResumeImporttests (resume re-queues the parse job for Parsing and Remediating; refused while the parse or remediation job is queued or running; refused for a Review import; refused for a user without write): red without the resume commit (6 errors), green with it.wikify.jobs.parse.runon a 6-page[test]import with batch size 2: the process wasSIGKILLed at page 5. Pages 1-4 were saved and the status stayed Remediating. A second run made 2 page-model calls (pages 5-6), reused the same Source Document and reached Review with 9 sections.SIGKILLed at page 5 (RQ moved the job to failed; status stayed Remediating). "Resume import" showed in Actions; clicking it ran pages 5-6 only on the same Source Document and the page moved to Review live. On a Completed import the item is hidden andresume_importreturns 417.deduplicate=Trueand a Parsing-status test (done); Vue review approved.