Repository navigation
feat(agent): let the assistant rename and merge section types - #84
Merged
Merged
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can ask the assistant on any import's Review screen to see it.
Fixes #41
Verification
test_agent_write.py(rename keeps sections; merge moves all sections and deletes the source; merging into itself, an unknown type or the catch-all type is refused; a non-System-Manager user is refused; the confirm card holds the merge and names both types and the count, then the approved run applies it): red on main (AttributeError), green on the branch. LLM call stubbed.[test]types on 3 sections; unapproved rename/merge changed nothing and showed "Move 2 section(s) from Section Type 'test_e2e_alpha' to 'test_e2e_beta', then delete 'test_e2e_alpha'."; approved runs renamed, then moved all 3 sections to the target and deleted the source; data restored.frappe.rename_doc(..., merge=True), so every link to the old type is repointed. The optionalconfirm_summaryonToolis the same field as in fix(agent): name the section in the delete confirm card #81.