Skip to content

fix(wiki): list the pages to be created in the publish dialog - #80

Merged
Rl0007 merged 2 commits into
mainfrom
fix/publish-preview
Oct 6, 2026
Merged

Rl0007 merged 2 commits into
mainfrom
fix/publish-preview

Conversation

@Rl0007

@Rl0007 Rl0007 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor
  1. The Publish dialog did not show which wiki pages it would create, so you had to publish to find out.
  2. The dialog now shows the page and group counts, the number of excluded sections, and the page titles nested under their groups (scrollable).

You can visit an approved import > Wiki tab > Publish to see it.

Fixes #44

Before

Before

After

After

Verification
  • Frontend-only change in WikiPublish.vue; it reuses the preview_wiki data the dialog already loaded and frappe-ui's Tree (as in SectionTree.vue). No Python change, so no new test.
  • Devbox e2e: approved a test import (9 sections), opened Publish: "8 pages · 1 group" and the nested titles show; with one section excluded it shows "7 pages · 1 group" and "1 excluded" (reverted afterwards). Nothing was published.
  • Vue and Frappe review: approved; heading changed to "Pages to publish" so it also fits Regenerate.
  • Merges cleanly with the other open PR in this file area (no new conflicted files).

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@Rl0007
Rl0007 merged commit fa036d9 into main Oct 6, 2026
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish dialog doesn't show which pages will be created

1 participant