Repository navigation
fix(sections): split a section at a paragraph start when no heading matches - #78
Merged
Merged
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can ask the assistant on any import's Wiki tab to split a section at a paragraph to see it.
Fixes #35
Verification
test_section_surgery: split a heading-less section at a paragraph start, and refuse an ambiguous start with nothing changed. Both failed on main ("No heading matching ...") and pass now. The existing heading-split tests still pass.split_sectiontool on a real parsed section at "Each page row carries". It made two siblings with the right text, and merging them back restored the original tree and text exactly. An ambiguous start ("the ", 2 matches; "- **", 5 matches) was refused, and the section was unchanged.