Skip to content

fix(ask): clear the composer after a question is sent - #75

Merged
Rl0007 merged 1 commit into
mainfrom
fix/ask-composer-clears
Oct 6, 2026
Merged

Rl0007 merged 1 commit into
mainfrom
fix/ask-composer-clears

Conversation

@Rl0007

@Rl0007 Rl0007 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor
  1. On Ask, a sent question stayed in the box, and the next question was typed into it and sent as one garbled question.
  2. The box now empties on send and shows its placeholder, and "New chat" starts empty.

You can visit /wikify/ask to see it.

Fixes #47

Before

Before

After

After

Verification
  • Cause: frappe-ui Textarea also emits on change; Chrome fires it on the focused landing textarea while it unmounts on send (logged in the browser: change value="[test] first question" after the clear), so v-model wrote the sent text back. The composer now updates only from input.
  • Frontend-only, no test runner; checked on a devbox with real key presses (type, Enter, New chat, type, Enter), no model configured.
  • Before (main): box kept "[test] first question"; the second question was stored as "[test] first question[test] second".
  • After (this branch): box empty with "Ask a follow-up…" after send, empty after New chat; second question stored as "[test] second".
  • vue-reviewer and frappe-reviewer: approve (merged two stacked comments per a nit).

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@Rl0007
Rl0007 merged commit e3b66c3 into main Oct 6, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ask box keeps the sent question and merges it into the next one

1 participant