Repository navigation
fix(agent): keep section ids in saved tool messages - #74
Merged
Merged
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can visit an import's Review screen, open the assistant and ask it to create a section, then ask a follow-up about that section to see it.
Fixes #34
Verification
<p7nnm9g8fb>; saving a chat message HTML-sanitizes it, so an id starting with a letter was read as a tag and removed. Ids are now wrapped in backticks in every tool/context text that prints them (and the prompt hints), which the sanitizer leaves alone. Turning sanitization off for the field was rejected: it needs a DocType change and drops XSS filtering on PDF-derived text.test_new_section_ids_survive_saving_the_tool_message(test_section_surgery): fails on main (stored rowCreated section '5. Epsilon' .), passes on this branch. One existing assertion in test_rag_api updated to the new format.[test]assistant session on a test import; the stored tool row kept the id (... '[test] fix-34 created section' `phfttbpobg`.); section and session deleted afterwards. No LLM involved.