Skip to content

fix(ask): confirm before deleting a conversation - #69

Merged
Rl0007 merged 2 commits into
mainfrom
fix/confirm-ask-delete
Oct 6, 2026
Merged

Rl0007 merged 2 commits into
mainfrom
fix/confirm-ask-delete

Conversation

@Rl0007

@Rl0007 Rl0007 commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor
  1. Clicking the trash icon next to an Ask conversation deleted it, with all its answers, on the first click.
  2. The trash icon now asks "Delete conversation?" first; Cancel keeps it, Delete removes it. The icon also has an accessible name now.

You can visit Ask, open History, and click the trash icon to see it.

Fixes #53

Before

After

Verification
  • Frontend-only change; the app has no frontend test runner, so the regression check is a browser run on a devbox.
  • Before (main): one click on trash removed the conversation from the list and from the DB (0 Wikify Ask Session rows); no dialog. The trash button's aria-label was null in the DOM.
  • After: trash opens a danger confirm; Cancel leaves the row in the list and the DB; Delete removes it (0 sessions, 0 messages).
  • The trash button now reads "Delete conversation: <title>" to screen readers (frappe-ui Button overwrites aria-label with its label prop).
  • pre-commit --all-files clean; Vue and Frappe reviews: approve.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@Rl0007
Rl0007 merged commit 680d326 into main Oct 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ask conversation is deleted on one click, without confirmation

1 participant