Repository navigation
fix(agent): make stop end the running turn - #68
Merged
Merged
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can visit the assistant panel in /wikify to see it.
Fixes #24
Verification
test_cancel_from_another_process_stops_the_tool_loop(LLM stubbed to always return a tool call, Stop set the way a separate web request leaves it): on main the turn ran all 25 LLM rounds; with the fix it stops after 1.test_agent: 29/29 pass.wikify.api.agent.cancelendpoint. On main the turn kept going to all 25 rounds, ended with "took too many steps", and a prompt sent right after Stop was rejected. With the fix the turn stopped about 1 s after Stop, and the next prompt was accepted.useAgentChat.js. No visible change after the turn ends; the Stop button stays up only until the server's complete event arrives.