Skip to content

fix(upload): keep the upload progress bar inside its row - #65

Merged
Rl0007 merged 3 commits into
mainfrom
fix/upload-progress-overflow
Oct 6, 2026
Merged

Rl0007 merged 3 commits into
mainfrom
fix/upload-progress-overflow

Conversation

@Rl0007

@Rl0007 Rl0007 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor
  1. While PDFs upload in the New Documents dialog, each progress bar stretches past the dialog edge and hides the file name.
  2. The progress bar now stays a small fixed width at the end of its row, and the file name shows next to it.

You can visit a project, click New Document and pick a few PDFs to see it.

Fixes #49

Before

After

Verification
  • Cause: frappe-ui Progress has w-full on its root, which overrode the w-20 passed to it. The fix moves the width onto a wrapper div.
  • Reproduced on a devbox on main with 4 long-named PDFs and the upload throttled to 8 KB/s: the bars ran past the queue border and hid the names. On this branch, after a rebuild, the bars stay inside their rows and the names truncate normally.
  • Frontend-only change; the app has no frontend test runner, so no automated test was added.
  • pre-commit (prettier) passes; vue-reviewer approved, frappe-reviewer approved once the after screenshot was added.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@Rl0007 Rl0007 mentioned this pull request Oct 6, 2026
8 tasks
@Rl0007
Rl0007 merged commit 5e7c220 into main Oct 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload progress bar overflows the New Documents dialog and hides the file name

1 participant