Skip to content

fix(tree): focus the rename box after the row menu closes - #62

Merged
Rl0007 merged 2 commits into
mainfrom
fix/rename-box-focus
Oct 6, 2026
Merged

Rl0007 merged 2 commits into
mainfrom
fix/rename-box-focus

Conversation

@Rl0007

@Rl0007 Rl0007 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor
  1. Choosing Rename from a section's "..." menu showed the edit box, but typing did nothing until you clicked into it.
  2. The box now gets focus with the title selected, so you can type the new name and press Enter right away.

You can visit an import's Wiki tab, open a section's "..." menu and pick Rename to see it.

Fixes #45

Before

After

Verification
  • Cause: the menu returns focus to its "..." button after its close animation, after the box had already taken focus. The box now takes focus back when that happens.
  • Before (main, devbox): after Rename, focus was on the "..." button and typing left the title unchanged.
  • After (devbox, real clicks and key presses): focus is in the box with the whole title selected. Typing "[test] renamed" and pressing Enter saved the new title in the database. The title was renamed back afterwards.
  • No frontend test runner in the app; the browser check above is the regression check.
  • vue-reviewer and frappe-reviewer: approve.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@Rl0007 Rl0007 mentioned this pull request Oct 6, 2026
8 tasks
@Rl0007
Rl0007 merged commit cc332f2 into main Oct 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename box isn't focused, so typing does nothing

1 participant