Repository navigation
feat(settings): put the settings dialog and its tab in the url - #60
Merged
Merged
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
vishwajeet-13
force-pushed
the
feat/settings-in-url
branch
from
October 5, 2026 18:09
b14f01c to
6a3376f
Compare
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56
Settings is now a URL as well as a dialog, like Commera:
/settings/:tabopens the dialog on that tab over the page you were on. Switching tabs updates the URL, Escape or Back closes it and returns to the page, and a pasted link like/wikify/settings/modelsopens straight on Models. Unknown tabs fall back to the first one.Screenshots
Open from a project

Switching tab updates the URL

Escape returns to the page
