Repository navigation
feat(scoring): score pdf-to-wiki conversion with jev - #20
Closed
vishwajeet-13 wants to merge 11 commits into
Closed
vishwajeet-13 wants to merge 11 commits into
vishwajeet-13 wants to merge 11 commits into
Conversation
Splits into two PRs: hiding Explore/generate-only Wiki tabs and folding publish into a renamed Tree->Wiki tab, then locking Regenerate after first publish and linking each page to its real editor in the Wiki app instead of round-tripping edits through Wikify. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Explore and the standalone generate-only Wiki tab are hidden (their components stay on disk, unreferenced). Tree is renamed to Wiki and now also carries the publish action, via a new compact WikiPublish control extracted from the old WikiGenerate.vue.
Remove the docs/superpowers spec + plan markdown files added while drafting this change - not meant to ship in the PR. Also reformats the Route FormControl in WikiPublish.vue to satisfy prettier (CI was failing the Frappe Linter job on line length).
Per review feedback - shrink the multi-line note explaining the tab list down to a single line.
- Legacy /import/:name/wiki links resolve to the consolidated "tree" (Wiki) panel instead of falling back to PDF. - WikiPublish's Publish/Regenerate button is always subtle, so "Approve & Build Graph" stays the toolbar's one solid action.
add_wiki_title_customizations() decided whether to (re)create the title-widening Property Setter by reading frappe.get_meta(), a process-level cache that isn't transaction-aware. In CI's full test run this let an earlier test's rolled-back Property Setter still read as present via the stale cache, so a later test's call skipped recreating it - leaving 0 rows where 1 was expected (test_running_again_keeps_one_property_setter). Check the Property Setter's own existence in the DB instead, which is what the function is actually trying to guarantee.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
vishwajeet-13
marked this pull request as draft
September 28, 2026 20:21
… invented Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vishwajeet-13
marked this pull request as ready for review
September 29, 2026 07:58
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
|
@NagariaHussain closing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scores how well each PDF converted to wiki using TypeSafe's Jev (via the existing OpenRouter key): per-page score + overall score on the import, with a Re-score with Jev button.
Opt-in via Settings → Scoring → Jev score (off by default). When on, Jev runs after parse and its score replaces the audit score in the UI. When off, no Jev calls are made and the audit score shows as before.
Screenshots
Setting

Pages, Jev on

Pages, Jev off (audit)

Logs, Jev on

🤖 Generated with Claude Code