Skip to content

feat(import-detail): collapse tabs to pdf/pages/wiki/logs - #18

Merged
Rl0007 merged 5 commits into
bwhtech:mainfrom
vishwajeet-13:main
Oct 5, 2026
Merged

Rl0007 merged 5 commits into
bwhtech:mainfrom
vishwajeet-13:main

Conversation

@vishwajeet-13

Copy link
Copy Markdown
Collaborator

What's done

  • Hid the Explore tab and the standalone generate-only Wiki tab (components untouched, just unreferenced).
  • Renamed Tree → Wiki. Tabs are now PDF · Pages · Wiki · Logs.
  • The Wiki tab now also publishes: a new compact WikiPublish control (extracted from WikiGenerate.vue) sits in the tree toolbar with Publish/Regenerate + a link to the generated space.

Screenshot

Wiki tab

Demo

page@b002e96425e6f87e4bedc577594c9b75.webm

@greptile-apps

greptile-apps Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because no outstanding or newly introduced correctness issues remain.

Summary

This PR consolidates the import-detail workflow into PDF, Pages, Wiki, and Logs tabs. It embeds publication controls into the section-tree toolbar, preserves legacy Wiki deep links, prevents empty generation, and repairs narrow Wiki title Property Setters.

  • Renames the Tree surface to Wiki and removes the standalone Explore and generation tabs.
  • Adds compact Wiki publication, regeneration, stopping, target selection, and completion handling.
  • Preserves /import/:name/wiki links by mapping them to the consolidated tree-backed Wiki tab.
  • Reads the persisted Property Setter value so existing narrow title fields are repaired.

Reviews (5) · Last reviewed commit: "style(wiki): trim comments and fix prett..."

Comment thread frontend/src/pages/ImportDetail.vue Resolved
Comment thread frontend/src/components/WikiPublish.vue Resolved
@vishwajeet-13 vishwajeet-13 changed the title Collapse Import Detail tabs to PDF/Pages/Wiki/Logs feat(import-detail): collapse tabs to pdf/pages/wiki/logs Sep 21, 2026
Comment thread frontend/src/components/WikiPublish.vue Resolved
Comment thread wikify/install.py Resolved
- install.py: check the Property Setter's value, not just its existence,
  so a setter left narrow by something else still gets repaired to
  Small Text.
- WikiPublish.vue: gate publish/regenerate on preview_wiki reporting at
  least one included section — regeneration sweeps every Wiki Document
  not backed by an included section, so publishing with nothing included
  could wipe an already-generated space down to its root group.

Addresses greptile-apps[bot] review findings on bwhtech#18.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vishwajeet-13

vishwajeet-13 commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator Author

Addressed both P1 findings in a964b65:

Invalid Setter Skips Repair (wikify/install.py — #18 (comment)) — now checks the Property Setter's value (via frappe.db.get_value) against WIDE_TEXT_FIELDTYPES, not just whether a setter row exists. A setter left narrow by something else now gets repaired to Small Text again.

Empty Wiki Can Publish (frontend/src/components/WikiPublish.vue — #18 (comment)) — WikiPublish.vue now calls preview_wiki on dialog open and gates canGenerate on there being at least one included section (pages + groups > 0), with a visible warning when the tree is empty. Prevents Regenerate from sweeping an already-published space down to its root group.

Pushed to this PR's branch.

vishwajeet-13 and others added 3 commits September 22, 2026 22:27
Per review: cut the comments down to what's genuinely non-obvious
(one line each) and fix the paragraph line-wrap prettier flagged in CI.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

# Conflicts:
#	frontend/src/pages/ImportDetail.vue

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@Rl0007
Rl0007 merged commit f14cf12 into bwhtech:main Oct 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants