Repository navigation
fix(agent): say when a section edit leaves the page in view unchanged - #104
Merged
Merged
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Pages tab, asking the agent to move or add something often changed only the section (wiki preview), so the page you were looking at stayed the same while the agent said "Done".
edit_section_contentnow tells the agent when the page in view is unchanged, so it must make the same edit on the page before reporting success. The hint stays quiet once the page was already edited in the same turn.Verification
bench --site wikify.localhost run-tests --module wikify.tests.test_agent_write: Ran 24 tests, OK (three new tests: hint for the page in view, none for pages outside the section, none once the page was edited this turn).test_agentandtest_agent_contentalso pass.Browser run on wikify.localhost: "move the page image to the top of this page" and "put the page 4 image before the first heading on this page" both moved the image on the page and in the section, and the agent's replies matched the data.