Repository navigation
fix(deps): bump vite to patched release for GHSA-p4f5-76q4-ffq7 - #747
Merged
Merged
Conversation
Vite 8.1.5 is affected by remote code execution through the `__vite-browser-external` virtual module when the dev server is exposed to the network. Raise the range to ^8.1.7, which resolves to 8.3.8 with rolldown 1.2.19. Yarn also pruned orphaned lockfile entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMKwzTNr9QKMY3285dvAgM
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
Backend test coverage: 94%Commit 3fa4368. Test modules are excluded. Coverage by file
111 empty files skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Bumps the dashboard's
vitefrom^8.1.5to^8.1.7. This fixes GHSA-p4f5-76q4-ffq7, a critical (CVSS 9.1) remote code execution flaw in the__vite-browser-externalvirtual module.--host/server.host, containers, shared dev boxes). Production serves the built assets and runs no Vite server. With no--host, the dev server listens only on localhost (Network: use --host to expose).@vue-flow/*,leaflet*,cropperjs,vuedraggable,sortablejs, etc.).After merging: run
yarn installindashboard/and restart any runningyarn devprocesses. A running server keeps the old code.Demo
No UI change. This is a dependency bump only (
skip-demo).Testing
Tested on a fresh bench (Frappe develop, bwh_payments v1-stable, Node 24), set up like
.github/actions/setup-bench:yarn buildpasses, andbench buildbuilds buzz.yarn typecheckpasses.yarn devserves/and/src/main.ts(200), and@framework/uiresolves from the bench's frappe app.guest-event.setup: the site has no SMS Settings ("Please configure SMS Settings… before enabling Phone OTP verification").form-builder(×2): the copied link comes back empty in headless Chromium.login-modal: the modal stays open after login.🤖 Generated with Claude Code
https://claude.ai/code/session_01XMKwzTNr9QKMY3285dvAgM