Repository navigation
feat(events): rebuild the create event page - #746
Open
harshtandiya wants to merge 7 commits into
Open
harshtandiya wants to merge 7 commits into
harshtandiya wants to merge 7 commits into
Conversation
One popover sets the whole schedule: Starts and Ends tabs, quick dates (today, tomorrow, day after, weekend), a month calendar and two time wheels that also take a typed time. After a start is picked it asks for the end; leaving without one keeps the event on the same day, and the end always stays after the start. The time zone sits beside it, named the way people say it, with the offset and city underneath.
"New event for <team>" leads the form, so the host is read before anything is typed. Organisers kept creating events under the wrong team when it sat as a small pill above the banner.
The page now covers the sidebar with its own bar (close, breadcrumb, Create) and runs as one column: host, banner, an underlined title so it reads as a field, about, when and where. Create sits in the bar until the end of the form scrolls into view, then moves there. A click with fields missing lists them beside the button and focuses the first one, replacing the always-on Still needed box.
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
|
✅ UI Demo Check — a screenshot or demo is attached. |
Contributor
Backend test coverage: 94%Commit 7dd6c0c. Test modules are excluded. Coverage by file
111 empty files skipped. |
bg-surface-white is not a token in this frappe-ui version, so the page, its sticky header and the schedule triggers rendered transparent and the banner showed through the header. Use surface-base, and lift the header above the banner.
The range popover is taller than a phone screen and opened clipped. On phones the schedule is now Starts and Ends rows, each with a date chip and a time chip; a chip opens its calendar or hour, minute and AM/PM wheels under its row, one at a time, so nothing covers the form. Desktop keeps the popover. The schedule parts move into their own folder.
On phones Create lives in a bar fixed to the bottom of the screen, under the thumb, and leaves the header; the list of missing fields opens above it at full width. The header's way out is a back chevron on every screen. The phone schedule rows drop their length line.
The Events / New event breadcrumb added little on a page the organiser leaves with the back button, so the header now carries one plain title on every screen.
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Create Event was doing too much at once, and people kept creating events under the wrong team. It's now a full-screen form with its own bar (back chevron, "Create New Event"):
Demo
Desktop
Mobile
Testing
Typecheck, oxlint and oxfmt pass. Checked phone layout at 375px in the browser. Updated
e2e/tests/create-event.spec.tsfor the missing-fields popover; left the run to CI.