Repository navigation
feat(booking): pay with Razorpay in the booking page - #740
Draft
harshtandiya wants to merge 1 commit into
Draft
harshtandiya wants to merge 1 commit into
harshtandiya wants to merge 1 commit into
Conversation
Paid bookings on a Razorpay event open Razorpay's checkout over the form instead of redirecting to a payment link. Other gateways, registration requests and sponsorships keep payment links. - open_booking_checkout asks bwh_payments for an inline checkout for the SDKs the dashboard can open (INLINE_CHECKOUT_SDKS) - get_booking_checkout_display shows the host's name and logo and the event title, locks the buyer's email and name, and closes the window when the ticket hold ends - the booking API answers with inline_checkout or payment_link - dashboard utils/checkouts: a lazily loaded adapter per SDK and useInlinePayment, which confirms the payment and moves on to the success page, never back to the form once paid
Contributor
Backend test coverage: 84%Commit 39052e0. Test modules are excluded. Coverage by file
110 empty files skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Paid bookings on a Razorpay event now open Razorpay's checkout over the booking form instead of redirecting to a payment link. Other gateways, registration requests, sponsorships and the resend-link email keep payment links.
open_booking_checkoutasks bwh_payments for an inline checkout for the SDKs the dashboard can open (INLINE_CHECKOUT_SDKS); the booking API answers withinline_checkoutorpayment_link.get_booking_checkout_display: the event host's name and logo, the event title, the buyer's email and name locked, and a timeout matching the ticket hold.utils/checkouts/: a lazily loaded adapter per SDK (Razorpay for now; PayU follows), a shared script loader, anduseInlinePayment, which confirms the payment and moves on to the success page. Closing the window keeps the buyer on the form; once paid they never return to it.Depends on bwhtech/bwh_payments#36. CI installs bwh_payments
v1-stable, so it fails until that is released.Demo
Testing
test_bookingcovers the inline response shape against bwh_payments'InlineCheckout;bookingSuccessRedirect.test.tscovers the new action. Manually, with Razorpay test keys: opened the modal on a paid event, closed it, then paid with a test card and landed on the success page with the booking confirmed.