You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
cloaked, undetected units have isCloaked() returning false #656
E.g. a cloaked, enemy Terran Wraith would have the following flags set:
exists() == true
isDetected() == false
isCloaked() == false
isBurrowed() == false
getHitPoints() == 0
the type will be correctly reported as Terran Wraith
Everything seems to be as expected except for isCloaked() returning false.
IMO, isCloaked() makes sense regardless of the owner. A human player is able to distinguish between a cloaked and a burrowed unit for example.
Perhaps, it wasn't clear, but I was talking about units which ARE in sight, just not detected by an own observer.
@heinermann to answer your question on IRC, this is the highest priority issue for me. As well as having enemy Sweep scans appear in the getAllUnits() result set
Activity
ajdvoynos commentedon May 4, 2016
Actually this seems the correct behavior to me. isCloaked() only makes sense on your own units, not the enemy.
If the enemy unit is not in sight(one of the reasons would be cloaking) you shouldn't be able to get any info on them.
krasi0 commentedon May 4, 2016
IMO, isCloaked() makes sense regardless of the owner. A human player is able to distinguish between a cloaked and a burrowed unit for example.
Perhaps, it wasn't clear, but I was talking about units which ARE in sight, just not detected by an own observer.
krasi0 commentedon Aug 8, 2016
@heinermann to answer your question on IRC, this is the highest priority issue for me. As well as having enemy Sweep scans appear in the getAllUnits() result set
Change isCloaked logic to include enemy units, fixes #656
N00byEdge commentedon Mar 7, 2019
TODO: Figure out what do to
N00byEdge commentedon Mar 7, 2019
...