Skip to content

cloaked, undetected units have isCloaked() returning false #656

Open

Description

@krasi0

E.g. a cloaked, enemy Terran Wraith would have the following flags set:
exists() == true
isDetected() == false
isCloaked() == false
isBurrowed() == false
getHitPoints() == 0
the type will be correctly reported as Terran Wraith

Everything seems to be as expected except for isCloaked() returning false.

Activity

  1. ajdvoynos commented on May 4, 2016

    @ajdvoynos

    Actually this seems the correct behavior to me. isCloaked() only makes sense on your own units, not the enemy.

    If the enemy unit is not in sight(one of the reasons would be cloaking) you shouldn't be able to get any info on them.

  2. krasi0 commented on May 4, 2016

    @krasi0
    ContributorAuthor

    IMO, isCloaked() makes sense regardless of the owner. A human player is able to distinguish between a cloaked and a burrowed unit for example.
    Perhaps, it wasn't clear, but I was talking about units which ARE in sight, just not detected by an own observer.

  3. added this to the 4.2.0 milestone on Jul 17, 2016
  4. krasi0 commented on Aug 8, 2016

    @krasi0
    ContributorAuthor

    @heinermann to answer your question on IRC, this is the highest priority issue for me. As well as having enemy Sweep scans appear in the getAllUnits() result set

  5. modified the milestones: 4.2.0, on Mar 19, 2017
  6. removed their assignment
    on May 8, 2017
  7. removed this from the milestone on Nov 27, 2017
  8. added a commit that references this issue on Mar 7, 2019
    80cee84
  9. N00byEdge commented on Mar 7, 2019

    @N00byEdge
    Member

    TODO: Figure out what do to

  10. N00byEdge commented on Mar 7, 2019

    @N00byEdge
    Member

    ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions