Buttons not added when Small/Big icons option is set #140

Activity

1. sasumner commented on Feb 2, 2020

   

   sasumner

   on Feb 2, 2020

   Last edited by sasumner

   More actions

   It's true, but it isn't only the Pythonscript toolbar buttons; other plugins don't get their buttons shown either, not sure which ones (or maybe all?) but for sure MarkdownViewer and NppExec (because those are the ones I use) that have toolbar buttons when "Standard" is selected, and they disappear if "Large" or "Small" is selected.

   Thus, not sure if it is a Pythonscript issue or a general Notepad++ issue, or both?
2. eugenesvk commented on Feb 2, 2020

   

   eugenesvk

   on Feb 2, 2020

   Author

   More actions

   Initially I thought it might be because only standard-sized icons are provided by this plugin, but I don't really know how toolbars work in NPP, so maybe it's indeed a general issue
3. chcg

   added

   N++ extension neededFirst a N++ modification is needed to work on thisFirst a N++ modification is needed to work on this

   on Jul 16, 2020
4. chcg commented on Jul 16, 2020

   

   chcg

   on Jul 16, 2020

   Collaborator

   More actions

   From a first look it seems there is no notification from N++ that the icon set size has changed and appropriate ones should be provided by the plugins, see https://npp-user-manual.org/docs/plugin-communication/#nppm-addtoolbaricon and https://npp-user-manual.org/docs/plugin-communication/#nppn-tbmodification and corresponding code around: https://github.com/notepad-plus-plus/notepad-plus-plus/blob/ade01204c8800c6117bdc72eb476de4226adf4fa/PowerEditor/src/WinControls/ToolBar/ToolBar.cpp#L346
5. chcg

   removed

   N++ extension neededFirst a N++ modification is needed to work on thisFirst a N++ modification is needed to work on this

   on Jan 7, 2025
6. chcg commented on Jan 7, 2025

   

   chcg

   on Jan 7, 2025

   Collaborator

   More actions

   In the meantime N++ (since https://notepad-plus-plus.org/downloads/v8/ ) this changed to Fluent UI icons. See also #366 which implemented the usage of ico files .