This repository was archived by the owner on Jan 21, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Jan 21, 2024. It is now read-only.
Change pages loses Vehicle/Possess/Dragon Riding state #494
Description
Issue description:
If you have a bar which is both paged and also Vehicle, Possess, or Dragon Riding (or a combo of). Then when in Vehicle, Possess, or Dragon Riding state, and you hit change page buttons then the bar will lose the Vehicle/Possess/Dragon Riding state, and show normal actions again.
There should either be someway of preventing it from changing Page when in Vehicle/Possess/Dragon Riding state, or someway of returning back to the Vehicle/Possess/Dragon Riding state.
How to reproduce:
- Create a Bar which is Paged, and also Dragon Riding
- Start Dragon Riding
- Bar will display Dragon Riding state
- Hit a Page button to change pages
- Bar will lose Dragon Riding state, and change to page requested by button
Technical info:
Addon Version: bbf339b
Client: Retail 10.0.2.47187
Personally see this as a low priority issue
Activity
ylixir commentedon Dec 19, 2022
hmm...maybe just disable paging in this case. seems simpler than figuring out a nice ux for switching back
Ketrel commentedon Dec 20, 2022
Disabling paging isn't a good option if you use paging on your main bar.
I think the most likely best solution to this would be to recheck the vehical/possess/riding state when returning to page 1 (but no other page)
ylixir commentedon Dec 20, 2022
can you walk me through that a little?
why shouldn't we disable paging when we are in a vehicle and paging and vehicles are both enabled for that bar?
and what do you mean recheck state when returning to page 1? we show the vehicle for page one but let them switch to other pages like normal?
anyone know how blizzard handles this off the top of their head?
TruthNZ commentedon Dec 20, 2022
Blizz's approach is to essentially disable paging, when a Vehicle bar is up.
I think either option here is suitable: Page 1 becomes the Vehicle Bar, or paging is disabled while you have a Vehicle Bar.
Ketrel commentedon Dec 21, 2022
Yes, but this addon is better than blizzard.
What would you lose if you do the following
If paging and vechicle override are both enabled, allow pages 2+ to work as normal, but when switching to page 1, re-check the vehicle, etc state and re-apply it if necessary.
That looks like it would give the best of both worlds.
ylixir commentedon Dec 21, 2022
what is the use case for wanting access to non vehicle abilities while in a vehicle? seems like best case they don't work, worst case they dismount you and you fall to your death.
are there places in the game where it makes sense do access another action bar while in a vehicle?
Ketrel commentedon Dec 21, 2022
You're going on the assumption that it's abilities on the other pages.
In many of my toons, the other page has things like bankstack/targeting/tomtom/other addon commands/etc
All things that I might use regardless of being in a vehicle
ylixir commentedon Dec 21, 2022
that makes sense. thanks!
TruthNZ commentedon Dec 21, 2022
My example is Death Knight Frost Walk, which I have on page 2, can be cast while mounted, and it's quite useful to be able to walk on water even on the Dragon Riding mount.