Skip to content
This repository was archived by the owner on Jan 21, 2024. It is now read-only.
This repository was archived by the owner on Jan 21, 2024. It is now read-only.

Having Blizzard Actionbars hidden in settings prevents ExtraActionButton from showing #477

Open

Description

@Ketrel

How to reproduce / Issue description:**

  1. Ensure that in the "Display the Blizzard UI" settings ActionBar is unchecked and Extra Action Bar is checked

Results: Extra Action Button is NOT displayed
Expected Results: Extra Action Button is displayed

Technical info:

  • Addon Version: commit 6d8a8c3
  • Client: Retail
  • Client Patch Version: 10.0.2

Additional context:

I've traced it to line 87 in Neuron-DisableBlizzardUI.lua which runs when Blizzard ActionBars are set to be hidden

ActionBarController:UnregisterAllEvents()  

The comment says that's to avoid potential for taints, but it unfortunately looks like it also prevents whatever event would show the blizzard extra action button.

Activity

  1. ylixir commented on Nov 28, 2022

    @ylixir
    Collaborator

    i haven't figured out a good place to test the extra action button (or the zone buttons)

    this isn't happening at a place that would be easy for me to test is it?

  2. brittyazel commented on Nov 28, 2022

    @brittyazel
    Owner

    Suramar City will activate both the Extra Button and the zone ability button

  3. Ketrel commented on Nov 28, 2022

    @Ketrel
    Author

    I used Suramar for my testing to isolate the line causing the issue.

    For zone, Draenor Garrison works as that's just zone, not extra.

  4. ylixir commented on Dec 3, 2022

    @ylixir
    Collaborator

    add vehicle exit button to this list as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions