This repository was archived by the owner on Oct 25, 2026. It is now read-only.
Repository navigation
Conversation
Contributor
Author
|
@diracdeltas this PR makes |
Member
|
looks good but we should make sure the output files work on all platforms. unfortunately i don't think we can test this by just checking the hash of the output files before and after this change because zip is non-deterministic :(. i probably won't get to it this week but will add it to my todo. cc'ing @emerick in case he has cycles |
Contributor
Author
|
@diracdeltas sorry for force-pushing, there was an merge conflict on the |
Member
|
assigning to @emerick for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.