Skip to content
This repository was archived by the owner on Oct 25, 2026. It is now read-only.

Fix npm run build failure on Windows platform - #14

Closed
cschanaj wants to merge 1 commit into
brave:masterfrom
cschanaj:fix-issue-5
Closed

cschanaj wants to merge 1 commit into
brave:masterfrom
cschanaj:fix-issue-5

Conversation

@cschanaj

Copy link
Copy Markdown
Contributor

No description provided.

@cschanaj cschanaj changed the title Drop *nix command dependency for cross-platform builds, fix #5 Drop *nix command dependency, fix #5 Jan 24, 2019
@cschanaj

Copy link
Copy Markdown
Contributor Author

@diracdeltas this PR makes https-everywhere-builder portable to Windows. Would you be interested to take a look?

@cschanaj cschanaj changed the title Drop *nix command dependency, fix #5 Fix npm run build failure on Windows platform May 15, 2019
@diracdeltas

Copy link
Copy Markdown
Member

looks good but we should make sure the output files work on all platforms. unfortunately i don't think we can test this by just checking the hash of the output files before and after this change because zip is non-deterministic :(.

i probably won't get to it this week but will add it to my todo. cc'ing @emerick in case he has cycles

@cschanaj

cschanaj commented Jul 6, 2019

Copy link
Copy Markdown
Contributor Author

@diracdeltas sorry for force-pushing, there was an merge conflict on the package.json file. please let me know if this is still needed. thanks.

@diracdeltas
diracdeltas requested a review from emerick July 16, 2019 17:08
@diracdeltas

Copy link
Copy Markdown
Member

assigning to @emerick for review

@cschanaj cschanaj closed this Aug 18, 2019
@cschanaj cschanaj reopened this Aug 18, 2019
@cschanaj cschanaj closed this Aug 18, 2019
@cschanaj
cschanaj deleted the fix-issue-5 branch August 18, 2019 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants