Repository navigation
Wrapped multi-errors should implement Unwrap() []error #38
Description
errtrace errors only implement Unwrap() error right now.
This hides the actual list of errors for wrapped multi-errors.
We need to implement Unwrap() []error if the error we're wrapping is a multi-error.
Alternatively, we can always implement only Unwrap() []error, and things should still just work.
Activity
abhinav commentedon Nov 28, 2023
Actually, this isn't quite right. Even with just
Unwrap() error, we're exposing the underlying list on the "next" layer, so it's not entirely inaccessible. But it's still going to be annoying. Although I'm not entirely certain that implementingUnwrap() []erroris the right choice there, because transparently skipping the actual wrapped error meansfmt.Errorf("information: %w %w", a, b)will unpack to a and b, ignoring information entirely.Separately, maybe we also need an
errtrace.Unwrapthat's a drop-in replacement forerrors.Unwrap, and all it does is transparently unwrap the top-level errtrace error—if any. That can be a separate discussion.[-]Wrapped multi-errors should implement Unwrap() []error[/-][+]Add errtrace.Unwrap() function as drop-in for errors.Unwrap[/+][-]Add errtrace.Unwrap() function as drop-in for errors.Unwrap[/-][+]Wrapped multi-errors should implement Unwrap() []error[/+]