Repository navigation
post-pull pre-stage stage (update hooks) #640
Description
This relates to:
- tracker: logically bound app images #128 (and Quadlet: add -list-images podman-container-tools/podman#23065 )
- check composefs compat when rebasing #632
- Provide warning when switching between distributions #610
Basically...I think it'd be a powerful general feature if we supported a flow that did:
- Pull new image (but without queuing a new bootloader entry)
- Run arbitrary code from the new image as a container
- Only on success, queue new bootloader entry
One simple way to do this would be to define a new bootc-pre-stage.target systemd unit that we run in between what currently happens when one types bootc upgrade.
This would be a clearly very powerful general mechanism that would allow implementing things like "logically bound container images" outside of bootc core code itself. A base image (or user code) could define which container images to pull via whatever mechanisms and file format it wants.
One could do arbitrary things like check compatibility (relates to #632 and #610)
The downside of course is that being so general, it'd be easy to use for things that would probably be best done elsewhere. I think we'd still eventually want higher level and more declarative/opinionated mechanisms for some of the problems here (especially the container binding one).
(This also tangentially relates to #2 in that it'd probably be a bit more elegant if we internally split up bits of the bootc upgrade process internally into units)
But...in ostree we already merged e.g. ostreedev/ostree#2569 which is currently a very special case.
Actually, a notable detail here is that bootc-pre-stage.target as proposed would get mutable access to the current /etc and the global /var, i.e. it'd be ordered before ostree-finalize-staged.target.
Activity
ckyrouac commentedon Jun 25, 2024
Interesting idea! It makes a lot of sense to me in general. One concern I have is around the shared state in
/varand/etc. This might not be a significant issue in practice. In theory, the new image might have incompatibilities with the existing state in/var, e.g. a major version upgrade of podman changes how images are stored in/var/lib/containers. I can also envision a scenario where an upgrade is staged, thebootc-pre-stagecode runs, creates some new state in /var, then the upgrade is cancelled. This would leave some possibly broken state in /var without some kind of a teardown/cleanup script.cgwalters commentedon Jun 25, 2024
I think anything executed here should be idempotent (being executed > 1 times is equivalent to 1 time) and crash safe (i.e. it can be killed at any point). That's how everything in the bootc/ostree stack is designed; i.e. if the kernel panics in the middle of an OS update, you only have image A or B, never a half-written mess. This can be a tricky property to achieve with arbitrary code. Actually, historically what happens during
podman pullhad bugs in this respect, and we probably need to re-audit its code in light of work on #215vrothberg commentedon Jun 28, 2024
I think we should consider using additional image stores.
All "pinned" images of one given bootc image can be pulled in a separate store. The store can then be made accessible to Podman by adding it to the storage.conf (which now supports drop-in files).
When bootc-updating to a new bootc image, the new pinned images can be pulled to yet another store. After a successful pull (or during boot), bootc can switch the additional image storage in storage.conf to the new one.
That should give us the desired idempotent behavior along with benefit of the "pinnged" images being read-only for Podman.
Removing old images would then boil down to
rm -rf-ing the old store.cgwalters commentedon Jun 28, 2024
(This issue is about the generic "run arbitrary code in new root" topic - WDYT about keeping #128 being focused on the "logically bound" container topic?)
I cleaned up #128 to clarify it's now just about "logically bound", as distinct from physically bound.
vrothberg commentedon Jul 1, 2024
SGTM
Merge pull request bootc-dev#640 from coreos/dependabot/cargo/widestr…
Merge pull request bootc-dev#640 from cgwalters/release
[-]post-pull pre-stage stage[/-][+]post-pull pre-stage stage (update hooks)[/+]