Repository navigation
Add dladdr minimal support for AIX - #114
Merged
Merged
Conversation
AIX doesn't provide dladdr syscall. This patch implements a minimal version in order to be able to compile stacktrace.
apolukhin
reviewed
Jun 10, 2024
apolukhin
left a comment
apolukhin
left a comment
Member
There was a problem hiding this comment.
I've noticed a leak in code, so changed it to store the std::string in Dl_info.
Not quite sure that the result compiles on AIX. Could you please give it a try and propose fixes if something is wrong?
Author
|
Sadly, I won't be able to do so, I don't have access to an AIX server anymore. I propose to let the user behind #89 tests this MR. Otherwise, you can either close it or merge as is hoping it works (the code being solely AIX it would be safe for other targets) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIX doesn't provide dladdr syscall. This patch implements a minimal
version in order to be able to compile stacktrace.