Skip to content

Fix CI #23

Description

@davidruegamer

Currently an old setup for Travis CI is used and hence automatic checks are broken.

Activity

  1. m-muecke commented on Mar 19, 2025

    @m-muecke
    Contributor

    Currently an old setup for Travis CI is used and hence automatic checks are broken.

    You open for using GitHub Actions? Then I could provide a PR.

  2. davidruegamer commented on Mar 19, 2025

    @davidruegamer
    MemberAuthor

    Yes and thank you! That would be awesome!

  3. m-muecke commented on Mar 20, 2025

    @m-muecke
    Contributor

    Yes and thank you! That would be awesome!

    Ok, great! You open for using testthat for testing? It's currently already in suggest, but afaik not really used.

  4. davidruegamer commented on Mar 20, 2025

    @davidruegamer
    MemberAuthor

    IIRC, we didn't use testthat because our tests take a long time. I would have to think about how to simplify them to avoid long CI waiting times.

  5. m-muecke commented on Mar 20, 2025

    @m-muecke
    Contributor

    IIRC, we didn't use testthat because our tests take a long time. I would have to think about how to simplify them to avoid long CI waiting times.

    What I generally do, when the tests are running too long for the CI is to add a skip call, e.g. skip_on_ci() and skip_on_cran()

  6. davidruegamer commented on Mar 20, 2025

    @davidruegamer
    MemberAuthor

    Good idea. Another option would be to skip all the factorization tests from @Almond-S and let the boosting routines in general_tests only run for one iteration via control = boost_control(mstop = 1). Since we do not do any type checking in this file, I guess we could go with tests that simply check for no error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions